[django] upgraded django to 4.1 #3945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitsrivastava
force-pushed
the
dev/amit/django-upgrade
branch
from
b6ef65f to
e1a6f9b
Compare
amitsrivastava
force-pushed
the
dev/amit/django-upgrade
branch
from
e1a6f9b to
ac0a9dd
Compare
Several other libraries have also been upgraded along with it. Four code changes had to be made. 1. Django 4 wants the middlewares to be explicitly sync and async. Rather than rewriting all of the middleware classes, I took the shortcut of creating a new mixin class that supports only sync calls. 2. CSRF_TRUSTED_ORIGINS in django 4+ need the scheme part as well. We now check and add `http` and `https` to the origins. 3. django-babel also needs a change every time we do a django upgrade. This is mostly just changes around django version support.
amitsrivastava
force-pushed
the
dev/amit/django-upgrade
branch
from
ac0a9dd to
1ab7b15
Compare
Harshg999
reviewed
Feb 6, 2025
Comment on lines
+164
to
+169
| ''' | ||
| Django4MiddlewareAdapterMixin has been solely added to migrate | ||
| Django3 middleware classes to Django4. Any new middleware | ||
| classes should try not to use this and instead follow the | ||
| standard practice at the time. | ||
| ''' |
Comment on lines
+503
to
+508
| for origin in TRUSTED_ORIGINS: | ||
| if 'http://' in origin or 'https://' in origin: | ||
| CSRF_TRUSTED_ORIGINS.append(origin) | ||
| else: | ||
| CSRF_TRUSTED_ORIGINS.append('http://%s' % origin) | ||
| CSRF_TRUSTED_ORIGINS.append('https://%s' % origin) |
There was a problem hiding this comment.
I'm a bit confused here @amitsrivastava , so if the origin is present in TRUSTED_ORIGINS, we are always appending one value in CSRF_TRUSTED_ORIGINS` else we are always appending two values for the same origin? Any reason why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several other libraries have also been upgraded along with it. Three code changes had to be made.
Django 4 wants the middlewares to be explicitly sync and async. Rather than rewriting all of the middleware classes, I took the shortcut of creating a new mixin class that supports only sync calls.
CSRF_TRUSTED_ORIGINS in django 4+ need the scheme part as well. We now check and add
httpandhttpsto the origins.django-babel also needs a change every time we do a django upgrade. This is mostly just changes around django version support.
There is also some change to our database support due to this. Following is the list of supported db versions.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.