-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui-serverLogs] Convert the Server Logs page within Administrator server in ReactJS #3927
Conversation
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
5176707
to
86d277d
Compare
386b1c7
to
acab827
Compare
595e5b0
to
b08201f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean! :-)
Just some minor comments.
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.test.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work as usual, I have a few questions and comments before hitting approve.
In general it would be useful for the PR reviewers to see some screenshots for this since it contains new UI.
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
80223b1
to
6875041
Compare
a34adb7
to
956e75a
Compare
WIP WIP Searchbox working WIP WIP WIP w f WIP r t WIP WIP WIP WIP WIP test
WIP
Wip
956e75a
to
2a58695
Compare
What changes were proposed in this pull request?
Update the Server logs page to use React and align it with the Cloudera Design Language.
For Seeing the logs on Server Logs tab, make sure to enable Gunicorn server in local system: Document
How was this patch tested?
Unit tests, manual testing
Updated ServerLogs page:
Please review Hue Contributing Guide before opening a pull request.