Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the backend meta generation for episodics to scale much nicer #11

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

CerealBoy
Copy link
Member

Checklist

  • Tagged appropriate reviewers.
  • Ran all appropriate tests.
  • Included details and screenshots in PR description.
  • Added references for any issues being actioned.

Description

Moving the episodic.meta generation into SQL, rather than loading all episodes for 1..x Episodic entries. This way, at least somewhat efficient querying is performed to generate the metadata rather than computing in Go, which itself was fast, more that there was a lot of data being put into memory for very little numbers.

Tests

Soon ™️.

@CerealBoy CerealBoy added the enhancement New feature or request label Jul 12, 2024
@CerealBoy CerealBoy self-assigned this Jul 12, 2024
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cloudcloud/episodical/pkg/data 0.00% (ø)
github.com/cloudcloud/episodical/pkg/server 0.00% (ø)
github.com/cloudcloud/episodical/pkg/types 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cloudcloud/episodical/pkg/data/episodic.go 0.00% (ø) 431 (+21) 0 431 (+21)
github.com/cloudcloud/episodical/pkg/data/loaders.go 0.00% (ø) 75 (-10) 0 75 (-10)
github.com/cloudcloud/episodical/pkg/server/handlers.go 0.00% (ø) 143 (-27) 0 143 (-27)
github.com/cloudcloud/episodical/pkg/server/server.go 0.00% (ø) 37 (+1) 0 37 (+1)
github.com/cloudcloud/episodical/pkg/types/collections.go 0.00% (ø) 173 0 173

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@CerealBoy CerealBoy merged commit 7ed1fb7 into main Jul 12, 2024
6 checks passed
@CerealBoy CerealBoy deleted the feature/improve-episodic-meta branch July 12, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant