Fix serialization of PSCustomObject wrapped object #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the switch away from converting PSCustomObjects to dictionaries we broke the way values that are wrapped in a PSCustomObject are serialized. This is evident when values of hashtables are generated using Write-Output which generates a PSCustomObject (Which is not evident in powershell, as there is a lot of magic in powershell), but is clearly evident when we try to use an object generated in PowerShell, in C#. This change looks at the nested type of a PSCustomObject, and unwraps it if it's not just another PSCustomObject. Fixes: cloudbase#157 Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Add a new type converter for IDictionary types which unwraps PScustomObjects before serializing. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch away from converting PSCustomObjects to dictionaries we broke the way values that are wrapped in a PSCustomObject are serialized.
This is evident when values of hashtables are generated using Write-Output which generates a PSCustomObject (Which is not evident in powershell, as there is a lot of magic in powershell), but is clearly evident when we try to use an object generated in PowerShell, in C#.
This change looks at the nested type of a PSCustomObject, and unwraps it if it's not just another PSCustomObject.
Fixes: #157