Add unit tests for Coriolis api

[Cristi1324]

This PR adds unit tests for Coriolis/api/middleware/auth.py

[Dany9966]

Some more changes required. For example, you did not check the result at all. You'll need to add a setUp method to set up the object you're testing, and also make use of testutils.get_wrapped_function to only test the underlying function, without calling webob.dec.wsgify decorator.

[Dany9966]

You don't need to mock every attribute of req_mock. The code you're testing will set these for you. Only keep req_mock, and directly set req_mock.headers = { key: value}.

[Dany9966]

Please remove these 3 lines

[Dany9966]

You don't really need to mock this. This only turns a JSON-formatted string into a dir. Instead of mocking its return value, you could do the following:

expected_service_catalog = {"catalog1": ["service1", "service2"]}
req_mock.headers = {
    # ...
    'X_SERVICE_CATALOG': str(expected_service_catalog), # this will turn your dir into a string
    # ...
}
# ...
# ...
mock_request_context.assert_called_once_with(
    # ...
    service_catalog=expected_service_catalog, # checks that the string from headers is the original dir
    # ...
)

[Dany9966]

Again, we don't call the actual tested code, we just assume the result. In this example, you passed '1,2,3', expected_roles should be ['1', '2', '3']', and that's what you should pass as roles, instead of mock_roles`

[Dany9966]

You can __call__ by result = CoriolisKeystoneContext(wsgi.Middleware)(req_mock)

[Dany9966]

Review pass done. Requesting changs. Please also add test cases for _get_user method.

[Dany9966]

Instead of returning an empty string, please raise an exception if no tenant is passed, as it should be impossible to instantiate a context without a tenant:

else:
    raise webob.exc.HTTPBadRequest(
        explanation=_("No 'X_TENANT_ID' or 'X_TENANT' passed."))

[Dany9966]

This should be self.auth.application

[Dany9966]

You don't need to assign a value to these mocks. Instead, please pass mock__get_project_id.return_value and mock_get_user.return_value to mock_request_context.assert_called_once_with() call.

[Dany9966]

Please replace this assert with assert_called_once_with(req_mock)

[Dany9966]

Please replace this assert with assert_called_once_with(req_mock)

[Dany9966]

NIT: Please replace 'mock_tennant' with 'mock_tenant'

[Dany9966]

NIT: Please replace 'mock_tennant' with 'mock_tenant'

[Dany9966]

Mostly LGTM

[Dany9966]

Please remove this, it doesn't seem like it's used anywhere

[Dany9966]

Please remove this also, it makes no sense to return an exception if we raise it in _get_user

[Dany9966]

NIT: as per the agreed upon guidelines, we only import modules as a whole (and not module methods or classes). Do not import objects, only modules (*) (source: https://docs.openstack.org/hacking/latest/user/hacking.html#imports)
Therefore, please import from coriolis.api.middleware import auth, and change all CoriolisKeystoneContext occurances to auth.CoriolisKeystoneContext.

[Dany9966]

LGTM