-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the build to use static libraries #180
base: main
Are you sure you want to change the base?
Conversation
It use to be static but then it was changed with 2e54b76 The Docker images we publish are built with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the simplest solution? :) I will let others merge this if they are OK with it
Unless I'm mistaken, that search shows that the tarball is built static, not the docker image? I was assuming that the Dockerfile in the root was what would be used to produce the docker images on dockerhub. Those are the images we are using, and the ones we've seen the bugs reported in this PR. I can see the previous commit that removes the static, and I've shown in #178 that this does indeed increase the image size - however this is from 11MB to 32MB - so I don't see it as a problem for most workloads. I would suggest that if the aim is to get a super small image, then all of the docker images need to be version pinned throughout the build process. |
Perhaps I'm missing something, but they don't appear to be:
|
Sorry I got that wrong. Thanks for checking. |
Np, appreciate you taking a look at all! |
Changes the build process to use static libraries. This does make the docker image bigger, but stops any library mismatches coming from using different
alpine:latest
images in chained docker images.Fixes #178
Fixes #174