Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Page Titles & Meta Tags #84

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix Page Titles & Meta Tags #84

merged 1 commit into from
Dec 4, 2024

Conversation

sknep
Copy link
Contributor

@sknep sknep commented Nov 13, 2024

Changes proposed in this pull request:

  • Uses Site name and domain, as well as description, to fill out meta tags
  • Works even if the site doesn't have a twitter acct

security considerations

N/A

@sknep sknep linked an issue Nov 13, 2024 that may be closed by this pull request
@sknep sknep requested review from Ephraim-G and apburnes November 13, 2024 23:23
_data/site.yaml Outdated Show resolved Hide resolved
_includes/meta.html Show resolved Hide resolved
Ephraim-G
Ephraim-G previously approved these changes Nov 18, 2024
@sknep
Copy link
Contributor Author

sknep commented Dec 3, 2024

@Ephraim-G can you approve again? It said one of my commits wasn't signed so i rebased with a new commit.

@Ephraim-G Ephraim-G self-requested a review December 4, 2024 17:21
@sknep sknep merged commit 0262b48 into main Dec 4, 2024
3 checks passed
@sknep sknep deleted the fix-meta-tags branch December 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page titles and meta tags aren't working
3 participants