Merge pull request #4344 from cloud-gov/chore-feature-flag-build-task

chore: reimplement build task feature flag handling
cloud-gov · Dec 21, 2023 · 1262ca6 · 1262ca6
2 parents b8dc8e7 + 3e964c0
commit 1262ca6
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/ci/pipeline-dev.yml b/ci/pipeline-dev.yml
@@ -68,7 +68,7 @@ jobs:
               APP_HOSTNAME: https://((((deploy-env))-pages-domain))
               NODE_ENV: development
               PROXY_DOMAIN: sites.((((deploy-env))-pages-domain))
-              FEATURE_BUILD_TASKS: true
+              FEATURE_BUILD_TASKS: 'active'
 
           - task: deploy-api
             file: src/ci/partials/deploy.yml

diff --git a/ci/pipeline-production.yml b/ci/pipeline-production.yml
@@ -68,7 +68,7 @@ jobs:
         params:
           APP_HOSTNAME: https://((((deploy-env))-pages-domain))
           PROXY_DOMAIN: sites.((((deploy-env))-pages-domain))
-          FEATURE_BUILD_TASKS: false
+          FEATURE_BUILD_TASKS: 'inactive'
 
 
       - task: deploy-api

diff --git a/ci/pipeline-staging.yml b/ci/pipeline-staging.yml
@@ -173,7 +173,7 @@ jobs:
         params:
           APP_HOSTNAME: https://((((deploy-env))-pages-domain))
           PROXY_DOMAIN: sites.((((deploy-env))-pages-domain))
-          FEATURE_BUILD_TASKS: true
+          FEATURE_BUILD_TASKS: 'active'
 
 
       - task: deploy-api

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -30,7 +30,7 @@ services:
       DOMAIN: localhost:1337
       FEATURE_AUTH_GITHUB: 'true'
       FEATURE_AUTH_UAA: 'true'
-      FEATURE_BUILD_TASKS: 'true'
+      FEATURE_BUILD_TASKS: 'active'
       PORT: 1337
       PRODUCT: pages
       UAA_HOST: http://localhost:9000

diff --git a/frontend/components/site/siteBuildLogs.jsx b/frontend/components/site/siteBuildLogs.jsx
@@ -20,7 +20,7 @@ const SiteBuildLogs = () => {
       <CommitSummary buildId={buildId} />
       <div className="log-tools">
         <ul className="usa-unstyled-list">
-          {(process.env.FEATURE_BUILD_TASKS) && (
+          {(process.env.FEATURE_BUILD_TASKS === 'active') && (
           <li><Link className="usa-button usa-button-secondary" to="./../scans">View scan results</Link></li>
           )}
           <li><DownloadBuildLogsButton buildId={buildId} buildLogsData={logs} /></li>

diff --git a/frontend/routes.js b/frontend/routes.js
@@ -51,7 +51,7 @@ export default (
       <Route path="custom-domains/new" element={<NewCustomDomain />} />
       <Route path="custom-domains/:domainId/edit" element={<EditCustomDomain />} />
       <Route path="builds/:buildId/logs" element={<SiteBuildLogs />} />
-      {(process.env.FEATURE_BUILD_TASKS) && (
+      {(process.env.FEATURE_BUILD_TASKS === 'active') && (
         <Route path="builds/:buildId/scans" element={<SiteBuildTasks />} />
       )}
     </Route>