Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proxy behavior #99

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Update proxy behavior #99

merged 2 commits into from
Nov 5, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Related to https://github.com/cloud-gov/private/issues/2015

  • Update proxy to set environment variables for the Redis backend used for session data

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Nothing about the actual security of how the proxy authenticates users is changing, the storage of the session data is just changing from a cookie in the browser to a cookie in the browser that references data stored in a backend. It is theoretically more secure for actual session data to reside in a backend that cannot be intercepted at the browser level.

@markdboyd markdboyd requested a review from a team as a code owner November 5, 2024 21:46
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@markdboyd markdboyd merged commit c5356cc into main Nov 5, 2024
1 check passed
@markdboyd markdboyd deleted the update-proxy-behavior branch November 5, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants