Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable private tenant #97

Merged
merged 1 commit into from
Oct 29, 2024
Merged

disable private tenant #97

merged 1 commit into from
Oct 29, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • add opensearch.multitenancy.private_tenant_enabled property to opensearch job spec
  • set default for opensearch.multitenancy.private_tenant_enabled to false so that private tenant will be disabled

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Disabling the private tenant will force users to use a tenant for their organization, meaning saved objects (visualizations, dashboards) will be visible to other users in their orgs

@markdboyd markdboyd requested a review from a team as a code owner October 29, 2024 20:13
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markdboyd markdboyd merged commit 9e96e3a into main Oct 29, 2024
1 check passed
@markdboyd markdboyd deleted the disable-private-tenant branch October 29, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants