Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multitenancy config for OpenSearch Dashboards #87

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • add more properties to opensearch_dashboards job spec for multitenancy
  • set default for opensearch_security.multitenancy.tenants.enable_private to false

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just changing multitenancy configuration for OpenSearch Dashboards

…y and set default for enable_private to false
@markdboyd markdboyd requested a review from a team as a code owner September 23, 2024 21:40
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@JasonTheMain JasonTheMain merged commit f392f68 into main Sep 24, 2024
1 check passed
@JasonTheMain JasonTheMain deleted the remove-private-tenant branch September 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants