Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yq blob #159

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Fix yq blob #159

merged 3 commits into from
Dec 13, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Related to #150

Right now, we get an error trying to run yq because the included blob is for the wrong architecture: Darwin (Mac) instead of Linux:

cannot execute binary file: Exec format error

This PR updates the yq blob to use Linux architecture instead of Darwin (Mac) architecture

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just fixing blob so yq can run successfully on the VMs

@markdboyd markdboyd requested a review from a team as a code owner December 13, 2024 21:51
@markdboyd markdboyd enabled auto-merge (squash) December 13, 2024 21:56
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crossing fingers

@markdboyd markdboyd merged commit fbb4818 into main Dec 13, 2024
1 check passed
@markdboyd markdboyd deleted the fix-yq-blob branch December 13, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants