Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pre-start script to only expect CF properties on data nodes #157

Merged
merged 2 commits into from
Dec 13, 2024
Merged

update pre-start script to only expect CF properties on data nodes #157

merged 2 commits into from
Dec 13, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Related to #150

  • update pre-start script to only expect CF properties on data nodes since only those needs run the securityadmin.sh script and need to prepare the security config files

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just fixing deployment errors

@markdboyd markdboyd requested a review from a team as a code owner December 13, 2024 20:44
JasonTheMain
JasonTheMain previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

JasonTheMain
JasonTheMain approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markdboyd markdboyd merged commit 351851a into main Dec 13, 2024
@markdboyd markdboyd deleted the fix-opensearch-job-cf-properties branch December 13, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonTheMain JasonTheMain JasonTheMain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @JasonTheMain