Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logstash filters for cloudwatch logs to drop unnecessary tags #125

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Drop tag values that are not useful for customers. The PlanGUID value is not actually the value of a CF service plan and the ServiceGUID value is not actually the GUID of a service offering

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@markdboyd markdboyd requested a review from a team as a code owner December 3, 2024 22:10
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd merged commit 936b1d5 into main Dec 3, 2024
1 check passed
@markdboyd markdboyd deleted the refactor-cloudwatch-log-ingest branch December 3, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants