Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no confusion #110

Merged
merged 2 commits into from
Nov 19, 2024
Merged

no confusion #110

merged 2 commits into from
Nov 19, 2024

Conversation

JasonTheMain
Copy link
Contributor

Changes proposed in this pull request:

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

[Note the any security considerations here, or make note of why there are none]

JasonTheMain and others added 2 commits November 18, 2024 11:43
Better naming

Co-authored-by: Mark Boyd <[email protected]>
Signed-off-by: Jason Gambino <[email protected]>
Opensearch ingestor with the ability to turn off the ingestor
@JasonTheMain JasonTheMain requested a review from a team as a code owner November 19, 2024 17:08
@JasonTheMain JasonTheMain merged commit 18ddaee into opensearch-ingestor Nov 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant