Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating proxy blob from v0.0.5 to v0.0.6 #108

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Related to https://github.com/cloud-gov/private/issues/2032

  • see title

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

See cloud-gov/opensearch-dashboards-cf-auth-proxy#146 for material changes to the proxy and discussion of security considerations

@markdboyd markdboyd requested a review from a team as a code owner November 15, 2024 15:57
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@markdboyd markdboyd merged commit 803553b into main Nov 15, 2024
1 check passed
@markdboyd markdboyd deleted the update-proxy-blob branch November 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants