Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proxy to send logs to file #104

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • see title

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just updating logging destination

@markdboyd markdboyd requested a review from a team as a code owner November 13, 2024 19:00
@markdboyd markdboyd enabled auto-merge (squash) November 13, 2024 19:00
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good addition

@markdboyd markdboyd merged commit 517bf48 into main Nov 13, 2024
1 check passed
@markdboyd markdboyd deleted the send-proxy-logs-to-file branch November 13, 2024 19:04
JasonTheMain added a commit that referenced this pull request Nov 13, 2024
update proxy to send logs to file (#104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants