Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proxy logging #103

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Update proxy logging #103

merged 4 commits into from
Nov 13, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Update proxy blob to v0.0.5
  • Updating proxy job to write its logs to stderr
  • add env var to control log level for proxy

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just updating logging to facilitate debugging

@markdboyd markdboyd requested a review from a team as a code owner November 13, 2024 17:23
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@markdboyd markdboyd merged commit 1f79ae4 into main Nov 13, 2024
1 check passed
@markdboyd markdboyd deleted the update-proxy-logging branch November 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants