Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSB pipeline is being split out to cloud-gov/csb repo #944

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

jameshochadel
Copy link
Contributor

Changes proposed in this pull request:

The set-self step on deploy-cf blocks when the deploy-cf-* jobs (or any other jobs in the pipeline) are running. This means that the deploy-apps- jobs may have to wait hours to get updated with changes merged to main. Moving the jobs to a separate pipeline will fix this issue. This will also focus each pipeline on a single responsibility. Lastly, developers will be able to set the deploy-csb pipeline to watch a topic branch for faster iteration without affecting CF deployments.

Related to cloud-gov/product#3216 because CF deployments were blocking iteration.

security considerations

None new.

The set-self step on deploy-cf blocks when the deploy-cf-* jobs (or any other jobs in the pipeline) are running. This means that the deploy-apps- jobs may have to wait hours to get updated with changes merged to main. Moving the jobs to a separate pipeline will fix this issue. This will also focus each pipeline on a single responsibility. Lastly, developers will be able to set the deploy-csb pipeline to watch a topic branch for faster iteration without affecting CF deployments.
@jameshochadel jameshochadel requested a review from a team as a code owner December 23, 2024 20:44
jameshochadel added a commit to cloud-gov/csb that referenced this pull request Dec 23, 2024
Compliment to PR: cloud-gov/deploy-cf#944

Reiterating the reasoning from that commit:

The set-self step on deploy-cf blocks when the deploy-cf-* jobs (or any other jobs in the pipeline) are running. This means that the deploy-apps- jobs may have to wait hours to get updated with changes merged to main. Moving the jobs to a separate pipeline will fix this issue. This will also focus each pipeline on a single responsibility. Lastly, developers will be able to set the deploy-csb pipeline to watch a topic branch for faster iteration without affecting CF deployments.

This also includes some code for deploying the docproxy.
jameshochadel added a commit to cloud-gov/csb that referenced this pull request Dec 23, 2024
Compliment to PR: cloud-gov/deploy-cf#944

Reiterating the reasoning from that commit:

The set-self step on deploy-cf blocks when the deploy-cf-* jobs (or any other jobs in the pipeline) are running. This means that the deploy-apps- jobs may have to wait hours to get updated with changes merged to main. Moving the jobs to a separate pipeline will fix this issue. This will also focus each pipeline on a single responsibility. Lastly, developers will be able to set the deploy-csb pipeline to watch a topic branch for faster iteration without affecting CF deployments.

This also includes some code for deploying the docproxy.
Copy link
Contributor

@cweibel cweibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@jameshochadel jameshochadel merged commit e76a169 into main Dec 23, 2024
1 check passed
@jameshochadel jameshochadel deleted the remove-csb-pipeline branch December 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants