Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update opensearch dashboards proxy client #927

Merged
merged 1 commit into from
Nov 4, 2024
Merged

update opensearch dashboards proxy client #927

merged 1 commit into from
Nov 4, 2024

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Nov 4, 2024 •
edited
Loading

Changes proposed in this pull request:

Related to https://github.com/cloud-gov/private/issues/2030

  • add client_credentials authorized grant type for opensearch dashboards proxy UAA client

security considerations

This client needs these permissions since the proxy uses the client_credentials flow to make requests to UAA

@markdboyd markdboyd requested a review from a team as a code owner November 4, 2024 20:30
JasonTheMain
JasonTheMain approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good fix

@markdboyd markdboyd merged commit 156b602 into main Nov 4, 2024
1 check passed
@markdboyd markdboyd deleted the update-opensearch-proxy-client branch November 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonTheMain JasonTheMain JasonTheMain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @JasonTheMain