Fix app zipfile for test CDN app #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcgottlieb
approved these changes
Nov 15, 2023
jameshochadel
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/cloud-gov/private/issues/888
Changes proposed in this pull request:
After #779, #780, and #781, the test CDN deployed correctly in staging, but visiting the URL gives a 403 error: https://test-cdn.fr-stage.cloud.gov/
The cause of the issue is that the source code for the app wasn't being zipped properly by the
zipperprovider. So Instead, I'm updating the code to the clone the source code manually and create the zip file using thearchive_fileresource built-in to Terraform.security considerations
None. These changes will fix deployment a "hello world" app which has no value except for allowing uptime monitoring of apps using a CDN.