Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in opensearch firehose #777

Merged
merged 7 commits into from
Oct 11, 2023
Merged

adding in opensearch firehose #777

merged 7 commits into from
Oct 11, 2023

Conversation

JasonTheMain
Copy link
Contributor

@JasonTheMain JasonTheMain commented Oct 10, 2023

Changes proposed in this pull request:

  • addition of new secret for opensearch-firehose
  • addition of logsearchv2-firehose for rotation of logsearchv1

security considerations

opensearch firehose secret will replace logsearch firehose when opensearch replaces.

@JasonTheMain JasonTheMain removed the request for review from soutenniza October 11, 2023 14:59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you manually generating the secret and uploading to credhub? You could add the secret as a variables block like 733f245

Copy link
Contributor

@cweibel cweibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variables are good, paths look correct, change to pipeline order of ops files should work

@JasonTheMain JasonTheMain merged commit 8d6fc81 into main Oct 11, 2023
@JasonTheMain JasonTheMain deleted the opensearch-secret branch October 11, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants