Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pipeline secrets to only use credhub #24

Merged
merged 1 commit into from
May 22, 2024
Merged

Switch pipeline secrets to only use credhub #24

merged 1 commit into from
May 22, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented May 21, 2024

Changes proposed in this pull request:

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

One less set of creds managed in s3, a bunch more to go...

@cweibel cweibel requested a review from a team May 21, 2024 20:56
service_organization: org1 org2
production:
service_organization: org3 org4 org5
- name: service_organization_development
Copy link
Contributor

@markdboyd markdboyd May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the full name of the credhub variable is longer, but perhaps not safe to document here in the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names of all the credhub variables, along with relative or absolute paths, are already available in all of our manifests and ops files.

Good eye though, that's why I didn't provide the credhub cli command to update it

@cweibel cweibel merged commit d749e1d into main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants