-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove user guid from all groups when orphaned #133
base: main
Are you sure you want to change the base?
Conversation
Although we don't have a consistent bash coding standard, I'm inclined to generally include |
echo "Usage: " | ||
echo " $0 <user-guid>" | ||
echo " " | ||
echo " <user-guid>: The guid of the user to remove from all groups." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GUID of the user to remove from all groups (up to 100, pagination not yet built-in)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you are commenting on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is more of an issue than I initially thought.
I was commenting on the usage text since, it would only remove the user from the first 100 groups returned by the uaac curl
call. I don't know if we're close to that limit or not.
It may be worth adding pagination if we're over, say, 50 groups total and may hit 100 in the next few years.
(I initially thought it was only an issue if the user themself was in more than 100 groups, but I see that I was wrong there)
I've picked some nits, but LGTM. |
Changes proposed in this pull request:
Remove an orphaned user group from all uaa groups. This occurs when a user is added to groups via
uaac member add
then deleted viacf delete-user
.security considerations
Cleans up orphaned users.