Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove clean_seekrets make target #93

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

bengerman13
Copy link
Contributor

seekrets has been deprecated for a very long time, so we don't need to think about it at all anymore

Changes proposed in this pull request:

  • remove clean_seekrets make target

security considerations

Because we audit caulking installations periodically, and git-seekrets has been deprecated for a long time, this should have no affect on our security posture

seekrets has been deprecated for a very long time, so we don't
need to think about it at all anymore
@bengerman13 bengerman13 requested review from a team as code owners December 18, 2024 19:14
Copy link
Contributor

@pburkholder pburkholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I especially approve your security considerations

@pburkholder pburkholder merged commit 3f05266 into main Dec 18, 2024
2 checks passed
@markdboyd
Copy link
Contributor

@bengerman13 Was the removal of the changes made in the README in #92 intentional? If so, I don't understand why

@markdboyd markdboyd deleted the bb/actually-stop-thinking-about-seekrets branch December 18, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants