Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Gemfile.lock
is an auto-generated file for Ruby dependency management viabundler
. It's the Ruby equivalent ofpackage-lock.json
in NodeSince it's an auto-generated file that we don't control the contents of, I don't think we need to scan it, at least for certain rules.
For example, without these changes I'm getting a lot of exceptions for the
IPv4 addresses
rule, but the contents aren't IP addresess, they're package versions such as:So this PR adds
Gemfile.lock
to be ignored for those rules, which I can confirm allowed me to commit myGemfile.lock
file locally with these changes.security considerations
We are updating the ignore patterns for GitLeaks, so we should agree that we are not ignoring potentially dangerous changes in
Gemfile.lock
files. However, since this file is auto-generated and not edited manually, I don't think that such concerns apply here.