Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added container-based VM tests #541

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bbenshab
Copy link

@bbenshab bbenshab commented Mar 2, 2023

Description

added container-based VM tests + updated README.md

Fixes

root and others added 2 commits March 2, 2023 17:59
run.sh - added the node-vm-density case
added folder node-vm-density - VM template and settings
added node-vm-density description
@comet-perf-ci
Copy link
Collaborator

Can one of the admins verify this patch?

disks:
- disk:
bus: virtio
name: node-vm-density
Copy link

@jeniferh jeniferh Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+            - disk:
+                bus: virtio
+              name: cloudinitdisk

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why?
some 1 might want to add more disks, and I like the name convention it fits the role

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the cloudInitNoCloud section to set pw / config ssh so this template would fail w/out defining the corresponding disk (error was: spec.template.spec.domain.volumes[1].name 'cloudinitdisk' not found)

@jtaleric
Copy link
Member

Could we add a check to the run.sh script to ensure the env has cnv/kubevirt setup for the test?

@jtaleric
Copy link
Member

jtaleric commented May 1, 2023

Could we add a check to the run.sh script to ensure the env has cnv/kubevirt setup for the test?

Checking @bbenshab if this is still relevant?

@jtaleric
Copy link
Member

jtaleric commented Jun 29, 2023

Could we add a check to the run.sh script to ensure the env has cnv/kubevirt setup for the test?

Checking @bbenshab if this is still relevant?

Checking in again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants