Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub feature #85

Closed
wants to merge 5 commits into from
Closed

Stub feature #85

wants to merge 5 commits into from

Conversation

chentex
Copy link
Member

@chentex chentex commented Feb 6, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Try to organize UI, for each organization to have it's own folder containing most of their data, this is the stub feature, that serves as an example and also helps teams build dynamically their custom dashboard.

The endpoint return the following:

  • startDate
  • endDate
  • data
  • columns dictionary
  • filters dictionary

The new homepage for the stub feature does the following:

  • With the columns dictionary generates a data table to display
  • With the filters dictionary generates all the filter components for the table

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@@ -38,7 +37,17 @@ export const SidebarLayout = ({sidebarComponents}) => {
/>
} />
}
else{
else if(component.isKeypair) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a part of this stub. Looks like this is meant to actually get added to the UI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need it to be able to reuse the same component

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtaleric
Copy link
Member

I wonder if we can have the stub page be optionally shown? We could leave much of the code in place, but do something with :

      {/* Nav link for stub page */}
      <ToolbarItem>
        <Link
          to="/stub"
          children={"Stub"}
          style={linkStyle("/stub")}
          onClick={() => setActive("/stub")}
        />
      </ToolbarItem>

We could add an option for local-compose to default to hiding stub?

@chentex
Copy link
Member Author

chentex commented Mar 1, 2024

I wonder if we can have the stub page be optionally shown? We could leave much of the code in place, but do something with :

      {/* Nav link for stub page */}
      <ToolbarItem>
        <Link
          to="/stub"
          children={"Stub"}
          style={linkStyle("/stub")}
          onClick={() => setActive("/stub")}
        />
      </ToolbarItem>

We could add an option for local-compose to default to hiding stub?

Yes, that was part of my idea to leave a commented section and instructions on the readme on how to enable it.

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 31, 2024
Copy link

github-actions bot commented Apr 5, 2024

This PR was closed because it has been stalled for 6 days with no activity.

@github-actions github-actions bot closed this Apr 5, 2024
@chentex
Copy link
Member Author

chentex commented Apr 9, 2024

I will re-open the PR when it's ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants