-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub feature #85
Stub feature #85
Conversation
Signed-off-by: Vicente Zepeda Mas <[email protected]>
Signed-off-by: Vicente Zepeda Mas <[email protected]>
Changing the data
Signed-off-by: Vicente Zepeda Mas <[email protected]>
@@ -38,7 +37,17 @@ export const SidebarLayout = ({sidebarComponents}) => { | |||
/> | |||
} /> | |||
} | |||
else{ | |||
else if(component.isKeypair) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look like a part of this stub. Looks like this is meant to actually get added to the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need it to be able to reuse the same component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I wonder if we can have the stub page be optionally shown? We could leave much of the code in place, but do something with :
We could add an option for local-compose to default to hiding stub? |
Yes, that was part of my idea to leave a commented section and instructions on the |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 6 days with no activity. |
I will re-open the PR when it's ready |
Type of change
Description
Try to organize UI, for each organization to have it's own folder containing most of their data, this is the stub feature, that serves as an example and also helps teams build dynamically their custom dashboard.
The endpoint return the following:
The new homepage for the stub feature does the following:
Related Tickets & Documents
Checklist before requesting a review
Testing