Improve and document the TableFilter component #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a notice when no filter options are present Reduces duplicate inputs by utilizing existing input to get necessary information Documents TableFilters and ColumnMenuFilter components
dbutenhof
reviewed
Feb 12, 2025
Adds documentation, and updates the message when no options are present
jaredoconnell
commented
Feb 12, 2025
dbutenhof
reviewed
Feb 13, 2025
MVarshini
reviewed
Feb 13, 2025
MVarshini
reviewed
Feb 13, 2025
MVarshini
reviewed
Feb 13, 2025
dbutenhof
approved these changes
Feb 13, 2025
dbutenhof
reviewed
Feb 20, 2025
| @@ -3,6 +3,7 @@ import "react-calendar/dist/Calendar.css"; | |||
| import "./index.less"; | |||
|
|
|||
| import { | |||
| Banner, | |||
There was a problem hiding this comment.
You added the Banner import, but I don't see it being used. Ah, well. I see you merged, so someone can clean it up later. I'll bet ESLint will catch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the TableFilter component confusing due to the duplicate input and lack of documentation. This PR aims to fix that.
This was entirely undocumented before, so let me know if I have any documentation errors.
Type of change
Description
Related Tickets & Documents
Checklist before requesting a review
Testing