Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark names #398

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chentex
Copy link
Member

@chentex chentex commented Nov 29, 2021

Description

Inconsistencies on naming have been having negative effects on our automation on image building.

  • Rename fs-drift tool to fs_drift
  • Rename upgrade tool to upgrade_openshift
  • Rename scale tool to scale_openshift

Fixes

#347

Signed-off-by: Vicente Zepeda Mas <[email protected]>
Fixing systemd analyze image for arm64

Signed-off-by: Vicente Zepeda Mas <[email protected]>
@sjug
Copy link
Collaborator

sjug commented Nov 29, 2021

Don't you need to change ycsb-server as well?

@chentex
Copy link
Member Author

chentex commented Nov 29, 2021

Don't you need to change ycsb-server as well?

Good catch!

Signed-off-by: Vicente Zepeda Mas <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #398 (b411745) into master (b9ddc34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          15       15           
  Lines         869      869           
=======================================
  Hits          342      342           
  Misses        527      527           
Flag Coverage Δ
gha 39.35% <ø> (ø)
python-3.6 39.35% <ø> (ø)
unit 39.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
snafu/utils/wrapper_factory.py 62.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ddc34...b411745. Read the comment docs.

@chentex chentex marked this pull request as draft November 29, 2021 16:31
@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/hammerdb PASS 00:06:04
snafu/smallfile_wrapper PASS 00:05:26
snafu/flent_wrapper PASS 00:07:29
snafu/scale_openshift_wrapper FAIL 00:03:10
snafu/sysbench PASS 00:02:52
snafu/benchmarks/uperf PASS 00:21:53
snafu/image_pull_wrapper PASS 00:03:28
snafu/ycsb_wrapper FAIL 00:13:02
snafu/stressng_wrapper PASS 00:03:36
snafu/fio_wrapper FAIL 00:31:47
snafu/log_generator_wrapper FAIL 00:01:54
snafu/upgrade_openshift_wrapper PASS 00:00:00
snafu/iperf FAIL 00:00:27
snafu/vegeta_wrapper FAIL 00:01:43
snafu/fs_drift_wrapper FAIL 00:01:47
snafu/pgbench_wrapper FAIL 00:02:24

Copy link
Collaborator

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can't find anything missing, but I'll try to do a more thorough double check with grep tomorrow.

@@ -1,11 +1,12 @@
FROM registry.access.redhat.com/ubi8:latest

RUN dnf install -y --nodocs git python3-pip && dnf clean all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test Kick off our CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants