Add enough feature to be able to parse clojure.core #21
Conversation
plexus
commented
May 25, 2018
plexus
commented
- metadata ^
- deref @...
- shorthand lambdas #(..)
- vars #'
- hex numbers
- regexes
plexus
force-pushed
the
add-more-syntax-features
branch
from
3350e63 to
4690a33
Compare
|
So |
- metadata ^ - deref @... - shorthand lambdas #(..) - vars #' - hex numbers - regexes
plexus
force-pushed
the
add-more-syntax-features
branch
from
4690a33 to
91c2ad8
Compare
test/parseclj-test.el
Outdated
| (:value . 123)))) | ||
| ((:node-type . :map) | ||
| (:position . 2) | ||
| (:children))))))))) |
There was a problem hiding this comment.
shouldn't the :map happen first?
There was a problem hiding this comment.
ah yes, good catch!
parseclj-lex.el
Outdated
|
|
||
| ((equal char ?`) | ||
| (right-char) | ||
| (parseclj-lex-token :backquote "'" pos)) |
There was a problem hiding this comment.
Also, I think there's a typeo here: "`" instead of "'"
Classic setup. I usually just copy/paste the new stuff in some |
|
Btw, do you plan to tag a release now that the parser is "feature-complete"? As you know I'd love to use it and parseedn in CIDER, but there has to be some release available for use with MELPA stable. |
|
Sure, sounds good! I just checked the backlog and it seems syntax-wise all we're missing are namespaced maps. What do you have in mind for it? It might still be too slow for a lot of use cases. Parsing clojure.core to an AST takes 2.24 seconds for me. It's a lot faster than the old edn.el, but still... OTOH we haven't really done any effort yet for optimizing things, maybe with some benching and tweaking we could get a significant speedup. |
|
Note also that clojure.core is 7700+ lines. On a 200 line file I was just working on it runs in 0.086 seconds, that might already be workable. |
I'm mostly hoping to implement better support for locals using it and some simple file-local refactorings. But what we need more right now is parseedn, so the cider-nrepl API could be unburned by the various Elisp limitations (e.g. some params are rather odd, because Elisp doesn't have booleans and some return values are also odd because the optimal return is not something we can read in Elisp - that's why almost all ops return just nested lists of strings). |
Namespaced maps are parsed to a regular :map AST token, but with an extra `:map-prefix` key, which is the map-prefix lex token.
|
I added namespace maps, AFAICT we should be able to parse all clojure syntax now. I'll merge this and tag a 0.1 release. |
