Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation with metadata #56

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

kommen
Copy link
Contributor

@kommen kommen commented Oct 28, 2024

The last part to fix #42

Split out and evolved from #43.
Porting more relevant testing infrastructure from clojure-mode

Eldev Outdated
@@ -10,7 +10,7 @@

(eldev-use-plugin 'autoloads)

(eldev-add-extra-dependencies 'test 'buttercup)
(eldev-add-extra-dependencies 'test 'buttercup 's)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given you've used only a single function from s, I'd rather us just add it as some test helper. Less is more. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@bbatsov bbatsov merged commit e69b0ac into clojure-emacs:main Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toplevel defs with metadata are not handled properly
2 participants