Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited doc update for info op #901

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ikappaki
Copy link
Contributor

Hi,

could you please review patch to do limited upated to the info op documentation. It partially addresses #885, specifically #885 (comment).

There are no functional changes. This update provides a reference for the basic usage of info, particularly clarifying that the file return key value should be either a URI or a relative path.

The new descriptions were determined empirically by examining log messages in CIDER. I'm open to corrections.

(Note: An unexpected expander entry appeared in the generated ops doc, which seems to have been missed in #894.)

Thanks

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • You've updated the README
  • Middleware documentation is up to date
    • Please check out and modify the cider.nrepl ns which has all middleware documentation.
    • Run lein docs afterwards, and commit the results.

Note: If you're just starting out to hack on cider-nrepl you might find
nREPL's documentation and the
"Design" section of the README extremely useful.*

Thanks!

(arglists-str, file, line, column, name, ns)

Sample CIDER response

(-->
  id         "18"
  op         "info"
  session    "cdbe8f64-e972-482c-9677-9ae456aaae96"
  time-stamp "2024-09-17 18:59:41.733894000"
  ns         "b"
  sym        "a/abc"
)
(<--
  id           "18"
  session      "cdbe8f64-e972-482c-9677-9ae456aaae96"
  time-stamp   "2024-09-17 18:59:41.736375000"
  arglists-str "[]"
  column       1
  file         "file:/D:/dev/clj/issue-cider-info/src/a.clj"
  line         3
  name         "abc"
  ns           "a"
  resource     "a.clj"
  status       ("done")
)
src/cider/nrepl.clj Outdated Show resolved Hide resolved
@bbatsov bbatsov merged commit 8026116 into clojure-emacs:master Sep 19, 2024
19 checks passed
@ikappaki
Copy link
Contributor Author

thanks @bbatsov!

Is it possible to regenerate the latest docs at https://docs.cider.mx/cider-nrepl/, or is it tied to the latest release?

@bbatsov
Copy link
Member

bbatsov commented Sep 19, 2024

@ikappaki Done. (it's a manual process)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants