Add support to list impls of protocol in info middleware
#568
Conversation
Use ns-imports of all namespaces to list all classes that
extend the protocol in question.
HACK - Modify classname to `map->{classname}`. The jump will only work for
defrecords at the moment.
|
@kapilreddy Thanks for looking in this! I think the right home for this code would be |
|
Makes sense. Will push the changes on orchard. |
|
Agree as well, I can maybe pick this up after clojure-emacs/orchard#37 is in |
|
@arichiardi I guess it's time to remind you of your promise. ;-) |
|
Ah ah definitely thanks for the reminder 😅 |
| "/map->" | ||
| (last xs)))) | ||
| x)] | ||
| {:candidates (into {} |
There was a problem hiding this comment.
is this returning :candidates? shouldn't it go in compliment?
There was a problem hiding this comment.
Those are different candidates. :-)
There was a problem hiding this comment.
I think we use the same key for several things here and there (I think it was used somewhere in info as well).
|
@arichiardi Any progress with this? |
|
@arichiardi Hey, Let me know if you need help moving this into Orchard and/or testing it. |
|
I think I need help yes, my Clojure time has been reduced substantially 😒 |
|
@bbatsov @arichiardi What's the status of this issue? |
|
It's waiting for a volunteer to drive it to the finish line. |
|
@kapilreddy Would you like to volunteer? |
|
Probably it doesn't make much sense to keep the PR open for yet another year, it's bit of a distraction when checking out our projects' status. Volunteering welcome! (Probably at Orchard level next time) |
Use ns-imports of all namespaces to list all classes that
extend the protocol in question.
HACK - Modify classname to
map->{classname}. The jump will only work fordefrecords at the moment.
clojure-emacs/orchard#204