Bump rust-toolchain to rust 1.87 #2749
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we're going to maintain a lower MSRV than we use for development, I'd like to ensure we have CI which runs with that version. |
|
I personally don't see a particularly strong motivation to not bump for bindings and its dependents as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This bumps our rust-toolchain in the file to 1.87, but doesn't bump the MSRV of the bindings crate and its dependents. We could, if we wanted to, but we don't really have an MSRV policy in place. This is necessary because the
v8crate has a fairly aggressive MSRV and I'd like to not fall too far behind from their latest version, since that's also the version of V8 itself.API and ABI breaking changes
Expected complexity level and risk
2 - rust version changes can cause problems but it's very rare
Testing