Cache with_label_values
more & don't do metrics while holding lock
#2734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Two things happen here that work together to improve performance:
with_label_values
are cached to the extent possible.Changes to
traits.rs
are:TxMetrics
and sometimes also the reducer name (String
) from theExecutionContext
.TxData
now exposes which tables were affected.Closes #1099 which was the first attempt at not reporting while holding the lock. The PR has since bitrotted.
API and ABI breaking changes
None
Expected complexity level and risk
3, most of the complication is where datastore transactionality is touched.
Testing
Should be covered by existing tests.