Reintroduce replication factor parameter #2718
Merged
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--num-replicas` option was removed from the CLI pre-1.0 It is re-introduced here as a hidden / unstable option to facilitate testing (e.g. to override defaults). The `DatabaseDef` type is changed to make `num_replicas` optional, so as to distinguish "use the default" (`None`) from "shut down all replicas but keep the database" (`Some(0)`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--num-replicasoption was removed from the CLI pre-1.0It is re-introduced here as a hidden / unstable option to facilitate
testing (e.g. to override defaults).
The
DatabaseDeftype is changed to makenum_replicasoptional, so asto distinguish "use the default" (
None) from "shut down all replicasbut keep the database" (
Some(0)).API and ABI breaking changes
Expected complexity level and risk
1
Testing