Skip to content

Single-threaded subscription evaluation #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshua-spacetime
Copy link
Collaborator

Description of Changes

Removes rayon from subscription evaluation and replaces its parallel iterators with sequential ones, the purpose of which is to optimize the common case of small updates where multithreading just adds overhead.

API and ABI breaking changes

None

Expected complexity level and risk

1

Just removes rayon and replaces into_par_iter() with into_iter().

Testing

  • Bot test

@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/no-double-compress-tx-updates branch from edd0b35 to 2a553a2 Compare April 30, 2025 15:57
Base automatically changed from joshua/perf/no-double-compress-tx-updates to master April 30, 2025 16:48
@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/single-threaded-subscription-eval branch from 2350a1f to 874c4b9 Compare April 30, 2025 17:05
@CLAassistant
Copy link

CLAassistant commented May 3, 2025

CLA assistant check
All committers have signed the CLA.

@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/single-threaded-subscription-eval branch from 874c4b9 to 77ff5bc Compare May 14, 2025 14:47
@joshua-spacetime joshua-spacetime marked this pull request as ready for review May 14, 2025 22:55
@joshua-spacetime joshua-spacetime requested a review from Centril May 14, 2025 22:55
@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/single-threaded-subscription-eval branch from 77ff5bc to 8f65cb6 Compare May 15, 2025 15:42
@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/single-threaded-subscription-eval branch from 8f65cb6 to ab0b1b5 Compare May 16, 2025 20:15
@bfops bfops added release-any To be landed in any release window performance A PR/Issue related to improving performance of stdb labels May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A PR/Issue related to improving performance of stdb release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants