Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace etaoin.impl.util/error with Slingshot throw+ #667

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Sep 16, 2024

Closes #666

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address. Not yet.

  • This PR contains test(s) to protect against future regressions. Not applicable.

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this change always conveying more information about the exception.
I mean :type :etaoin/failed is pretty generic.
But when Etaoin throws, you are being more consistent in the shape of the thing it throws.

I commented in the issue that this could be technically breaking, but probably not worth worrying about. Folks should not be relying on exception messages, and even if they are, you've not changed them.

I appreciate all the attention you are giving to Etaoin but this is on the nitty-gritty level that I don't really care about for a project like Etaoin. It feels like cleanup for cleanup's sake, and I'm not sure who it really benefits.

It does give a clear message to developers of Etaoin they should be using throw+ when throwing, so there's that.

And I guess it won't hurt any users of Etaoin.

@lread lread merged commit 1ea781e into clj-commons:master Sep 16, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-666-replace-util-error branch September 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error handling by replacing etaoin.impl.util/error with throw+
2 participants