Stabilize aleph.http-test/test-idle-timeout
#627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerGuteMoritz
requested review from
arnaudgeiser and
KingMob
as code owners
DerGuteMoritz
force-pushed
the
stabilize-test-idle-timeout
branch
from
d8e2dc8 to
90686aa
Compare
KingMob
reviewed
Sep 11, 2022
KingMob
approved these changes
Sep 11, 2022
DerGuteMoritz
force-pushed
the
stabilize-test-idle-timeout
branch
from
90686aa to
e337498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #626.
More like a workaround but given how
byte-streamsworks, I can't see how to better fix this. Maybe look into optimizing the conversion path construction?