forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD Permission and Permission Evaluation POC 2.0.2 #2
Open
cliu123
wants to merge
8
commits into
2.0
Choose a base branch
from
permission_poc_2.0.2
base: 2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#1550) (opensearch-project#1707) * Fix WMS can't load when unable access maps services Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit b2cfb6e)
…ct#1750) Signed-off-by: Tommy Markley <[email protected]> (cherry picked from commit 72a3424) Co-authored-by: Tommy Markley <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
fac0719
to
b7956d0
Compare
…ved object. Reference: multi-data-source POC<https://github.com/seraphjiang/OpenSearch-Dashboards/pull/1/files> Signed-off-by: Chang Liu <[email protected]>
Signed-off-by: Chang Liu <[email protected]>
Signed-off-by: Chang Liu <[email protected]>
b7956d0
to
0399abf
Compare
seraphjiang
reviewed
Jul 5, 2022
Comment on lines
12
to
29
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we remove elastic license head~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Chang Liu <[email protected]>
414c9db
to
9dffe07
Compare
Signed-off-by: Chang Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference on saved object registration: multi-data-source POC
Description
The POC proves:
.kibana
index. So the it could have granular access control on inidividual saved objects without relying on tenant. Tenant could be removed..kibana
) that doesn't rely on OpenSearch security plugin that stores permissions and access policies in security configuration index and evaluate priviledges.APIs
Create
sample-permission
saved object:Find all
sample_permission
saved objects:Get a
sample_permission
saved object by id:Evaluate permissions:
{"authorized":"false"}
):{"authorized":"true"}
):