Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics is included under the Site admin #11

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions google_analytics/admin.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
from google_analytics.models import Analytics
from .models import Analytics
from django.contrib import admin
from django.contrib.sites.admin import SiteAdmin, Site

admin.site.register(Analytics)
class AnalyticsInlineAdmin(admin.StackedInline):
model = Analytics

class AnalyticsSiteAdmin(SiteAdmin):
inlines = [AnalyticsInlineAdmin]

admin.site.unregister(Site)
admin.site.register(Site, AnalyticsSiteAdmin)
6 changes: 5 additions & 1 deletion google_analytics/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
from django.contrib.sites.models import Site

class Analytics(models.Model):
site = models.ForeignKey(Site)
site = models.OneToOneField(Site)
analytics_code = models.CharField(blank=True, max_length=100)
analytics_domain = models.CharField(blank=True, max_length=100,
help_text="You can set here the analytics domain to merge reports with other sites")
track_page_load = models.BooleanField("Track page load time",
blank=True, default=False)

def __unicode__(self):
return u"%s" % (self.analytics_code)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script type="text/javascript">
var _gaq = _gaq || [];
_gaq.push(['_setAccount', '{{ analytics_code }}']);
{% if analytics_domain %}_gaq.push(['_setDomainName', '{{ analytics_domain }}']);{% endif %}
_gaq.push(['_trackPageview']);

{% if track_page_load_time %}
Expand Down
26 changes: 14 additions & 12 deletions google_analytics/templatetags/analytics.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
from django import template
from django.conf import settings
from django.db import models
from ..models import Analytics
from django.contrib.sites.models import Site

from django.template import Context, loader


register = template.Library()
Analytics = models.get_model('googleanalytics', 'analytics')

def do_get_analytics(parser, token):
contents = token.split_contents()
Expand Down Expand Up @@ -40,23 +39,26 @@ def __init__(self, site=None, code=None, template_name='google_analytics/analyti
def render(self, context):
content = ''
if self.site:
code_set = self.site.analytics_set.all()
if code_set:
code = code_set[0].analytics_code
else:
try:
code = self.site.analytics
except Analytics.DoesNotExist:
return ''

elif self.code:
code = self.code
code = type('Code', (object,), {
'analytics_code': self.code,
'analytics_domain': '',
'track_page_load': False
})()
else:
return ''

if code.strip() != '':
if code.analytics_code.strip() != '':
t = loader.get_template(self.template_name)
c = Context({
'analytics_code': code,
'track_page_load_time': getattr(settings,
"GOOGLE_ANALYTICS_TRACK_PAGE_LOAD_TIME",
False),
'analytics_code': code.analytics_code,
'analytics_domain': code.analytics_domain,
'track_page_load_time': code.track_page_load,
})
return t.render(c)
else:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from distutils.core import setup
from setuptools import setup

setup(name='google_analytics',
version='0.2',
Expand Down