Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scores should be re-considered #6

Open
kojima-r opened this issue Jul 16, 2021 · 1 comment
Open

scores should be re-considered #6

kojima-r opened this issue Jul 16, 2021 · 1 comment

Comments

@kojima-r
Copy link
Member

https://github.com/clinfo/GraphGenerativeModel/blob/master/lib/models.py#L109

scores and or 1/node.visits should be re-considered

np.array([abs(node.performance) / node.visits for node in candidates])

@vincrichard
Copy link
Collaborator

Thank you for the notice. Right now we are working with a tree policy instead of this approach. The policy follows more or less the same condition as UnitMCTS paper you shared. It will be added when we push a first version of the code.

vincrichard added a commit that referenced this issue Aug 31, 2021
[fix] enabling aromatic reward only for aromatic mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants