add additional options for clickhouse support #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, readonly and debug advanced options Signed-off-by: Slach <[email protected]>
|
Thank you for the contribution! Will check this out soon but meanwhile, could you add some test demo? We were trying to keep a record. Super excited to see the PR though! |
Which kind of test demo do you mean? I don't see *_test.go files |
|
Yeah sorry, I meant like a screen share how it works and that everything is loading. We are going to add unit tests soon but not the priority right now. |
|
there is screencast about connection worked whodb_clickhouse_screencast.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support HTTP protocol, SSL mode, Readonly and Debug advanced options