Skip to content

feat(clerk-js): Initiate enterprise SSO from ticket flows #6009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented May 26, 2025

Description

We've introduced FAPI changes to return missing_requirements / needs_first_factor when a sign-in/sign-up gets created with an org invite that is related to an active enterprise connection.

This PR updates the ticket flows to check against those new statuses and initiate enterprise SSO redirection.

CleanShot.2025-06-03.at.18.56.34.mp4

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this May 26, 2025
Copy link

changeset-bot bot commented May 26, 2025

🦋 Changeset detected

Latest commit: ef1ac0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 5:03pm

Copy link

pkg-pr-new bot commented Jun 3, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6009

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6009

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6009

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6009

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6009

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6009

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6009

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6009

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6009

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6009

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6009

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6009

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6009

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6009

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6009

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6009

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6009

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6009

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6009

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6009

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6009

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6009

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6009

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6009

commit: ef1ac0c

@LauraBeatris LauraBeatris requested a review from a team June 3, 2025 22:06
@LauraBeatris LauraBeatris force-pushed the laura/org-invite-ticket-with-sso branch from 7edc159 to 58356f8 Compare June 3, 2025 22:07
Copy link
Contributor

@NicolasLopes7 NicolasLopes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me!

Question: Is this OIDC prompt change related with this PR?

@LauraBeatris
Copy link
Member Author

Changes looks good to me!

Question: Is this OIDC prompt change related with this PR?

@NicolasLopes7 That's correct! We need to forward oidcPrompt to every single enterprise SSO call now.

@LauraBeatris LauraBeatris force-pushed the laura/org-invite-ticket-with-sso branch from 5fd7f5c to ef1ac0c Compare June 4, 2025 17:02
@LauraBeatris LauraBeatris merged commit 32a5e11 into main Jun 4, 2025
36 checks passed
@LauraBeatris LauraBeatris deleted the laura/org-invite-ticket-with-sso branch June 4, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants