-
Notifications
You must be signed in to change notification settings - Fork 333
feat(backend): Add sign ups to Backend API client #5625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f408a7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A new feature has been introduced to support retrieving and updating sign up attempts in the backend API client.
- Updated exports and JSON interfaces to incorporate SignUpAttempt types.
- Added a new SignUpAttempt resource class with corresponding deserialization.
- Introduced a new SignUpAPI endpoint with GET and PATCH methods.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/backend/src/index.ts | Updated exports to include SignUpAttempt types. |
packages/backend/src/api/resources/index.ts | Exported the new SignUpAttempt resource and updated sign up types. |
packages/backend/src/api/resources/SignUpAttempt.ts | Added the SignUpAttempt resource and JSON conversion logic. |
packages/backend/src/api/resources/JSON.ts | Updated JSON interfaces to match the new SignUpAttempt structure. |
packages/backend/src/api/resources/Enums.ts | Removed SignUpStatus and added SignUpVerificationNextAction type. |
packages/backend/src/api/resources/Deserializer.ts | Integrated SignUpAttempt deserialization into the API client. |
packages/backend/src/api/factory.ts | Added instantiation of SignUpAPI in the backend API client factory. |
packages/backend/src/api/endpoints/index.ts | Exported the new SignUpApi endpoint. |
packages/backend/src/api/endpoints/SignUpApi.ts | Implemented GET and PATCH endpoints for sign up attempts. |
.changeset/smooth-ways-arrive.md | Added a changeset documenting the new sign up attempts feature. |
} from './Enums'; | ||
|
||
export type { SignUpStatus } from '@clerk/types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this re-export needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacekradko In theory, no, but I added it to keep consistency with the code above:
SignInStatus,
} from './Enums';
421b103
to
32a77bf
Compare
32a77bf
to
f408a7a
Compare
Description
Adds the ability to retrieve and update Sign Up Attemps to the Backend API client.
ECO-590
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change