-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-js): Remove non-actionable error from Session poller #5494
chore(clerk-js): Remove non-actionable error from Session poller #5494
Conversation
🦋 Changeset detectedLatest commit: b3367df The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dd304a5
to
74d22ca
Compare
//throw if not a clerk api error (aka fapi error) and not a network error | ||
if (!isClerkAPIResponseError(e) && !isClerkRuntimeError(e)) { | ||
clerkCoreErrorTokenRefreshFailed(e.message || e); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will removing this impact the is4xxError
check below? I think most likely not, but wondering if we want to early return on non clerk API / runtime errors (as this implicitly does today)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the non-actionable error handling from the Session poller.
- Removed the clerkCoreErrorTokenRefreshFailed function from errors.ts.
- Updated AuthCookieService.ts to eliminate throwing an error on non-4XX scenarios during token refresh.
- Added a changeset entry confirming the patch release.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/clerk-js/src/core/errors.ts | Removed the non-actionable error function. |
packages/clerk-js/src/core/auth/AuthCookieService.ts | Removed the error throw for non-clerk API/runtime errors, aligning with the PR purpose. |
.changeset/fresh-numbers-sink.md | Added changeset information for the patch release. |
!snapshot |
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
Description
Only perform actionable steps when Session poller fails to fetch a fresh token.
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change