Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support OAuth Applications #353

Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat: Support OAuth Applications #353

merged 1 commit into from
Nov 14, 2024

Conversation

AlexNti
Copy link
Member

@AlexNti AlexNti commented Nov 13, 2024 •
edited
Loading

In this commit we are adding the CRUD methods and the rotate client secret for for OAuth Applications, the documentation for those API can be found at https://clerk.com/docs/reference/backend-api/tag/OAuth-Applications

@AlexNti AlexNti changed the title chore: Fix failing rotate secret feat: Support OAuth Applications Nov 13, 2024
@AlexNti AlexNti force-pushed the ntitoras/user-1013-introduce-oauth-application-operations-to-go-sdk branch from c1102d3 to b13cd71 Compare November 14, 2024 10:27
@AlexNti AlexNti marked this pull request as ready for review November 14, 2024 10:28
@AlexNti AlexNti requested a review from a team as a code owner November 14, 2024 10:28
gkats
gkats reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @AlexNti!

I've left some comments, let me know what you think.

oauthapplication/client.go Outdated Show resolved Hide resolved
oauthapplication/client.go Show resolved Hide resolved
oauthapplication/client.go Outdated Show resolved Hide resolved
oauthapplication/client.go Outdated Show resolved Hide resolved
oauthapplication/client.go Outdated Show resolved Hide resolved
oauthapplication/client.go Outdated Show resolved Hide resolved
oauthapplication/client.go Outdated Show resolved Hide resolved
oauthapplication/client.go Outdated Show resolved Hide resolved
oauth_application.go Outdated Show resolved Hide resolved
gkats
gkats approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before you merge this one, could you please also update the CHANGELOG?

You can add a "Next release" with your changes for now. See this PR for an example.

@AlexNti
feat: Add support for OAuth applications
2fcc202 
In this commit we are adding the CRUD methods and the rotate client secret for  for OAuth Applications, the documentation for those API can be found at https://clerk.com/docs/reference/backend-api/tag/OAuth-Applications
@AlexNti AlexNti force-pushed the ntitoras/user-1013-introduce-oauth-application-operations-to-go-sdk branch from 8911d69 to 2fcc202 Compare November 14, 2024 12:05
@AlexNti AlexNti merged commit 0fb1285 into v2 Nov 14, 2024
7 checks passed
@AlexNti AlexNti deleted the ntitoras/user-1013-introduce-oauth-application-operations-to-go-sdk branch November 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkats gkats gkats approved these changes

@chanioxaris chanioxaris Awaiting requested review from chanioxaris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexNti @gkats