Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invitations): Support multiple statuses #324

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

kostaspt
Copy link
Member

In this PR, we update the invitations to allow filtering by multiple statuses instead of just one, since we already support this in Backend API.

@kostaspt kostaspt requested a review from a team as a code owner September 10, 2024 14:56
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. What version are we planning to release this in?

@mzhong9723
Copy link
Member

This is a breaking change. What version are we planning to release this in?

It would be a different version of the SDK right? The API itself isn't changing.

@kostaspt Maybe we can support the previous parameter as well, and give it priority if it is set.

@kostaspt
Copy link
Member Author

This is a breaking change. What version are we planning to release this in?

We added this in 84b590a, and the last release was commit 240f3a5 [2.0.8] (one before). So we haven’t released this change yet.

Another safe approach is to follow what @mzhong9723 suggested and deprecate it.

@gkats
Copy link
Member

gkats commented Sep 10, 2024

@kostaspt If there's no tagged version for v2 with the Status field then we're ok to merge. 👍

@kostaspt kostaspt merged commit 807c124 into v2 Sep 10, 2024
5 checks passed
@kostaspt kostaspt deleted the kostas/accept-multiple-statuses branch September 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants