Prefer absolute path resolves #6919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jbroadus
reviewed
Feb 12, 2021
|
This has been verified to resolve the closed #5351, where it's been pointed out that ratings etc. won't work with any path except the one in the library. This is expected to be correct now for a file beyond a symlink, e.g. the path added to the library, whether it contains a symlink or not, can be used to set a rating on a file without the user having to obtain the file path that was actually added to the database or look up the file via the library. |
smithjd15
changed the title
smithjd15
force-pushed
the
absoluteLibraryPath
branch
2 times, most recently
from
89953e1 to
ac0e371
Compare
smithjd15
changed the title
smithjd15
force-pushed
the
absoluteLibraryPath
branch
from
ac0e371 to
1631d5b
Compare
…le paths in relative path saved playlists.
smithjd15
force-pushed
the
absoluteLibraryPath
branch
from
1631d5b to
004c4cf
Compare
|
Closes #5356. |
|
Closes #2299. |
smithjd15
force-pushed
the
absoluteLibraryPath
branch
from
4965374 to
6931583
Compare
|
Closes #5065. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset is part one of three of a series to improve Clementine's creation and maintenance of (portable) playlists.
Canonical path conversion resolves symlinks and dot-segments, breaking saving of portable relative path playlists. Rectify this by using absolute path resolves everywhere canonical resolves were used priorly. Playlist path resolves are already described as absolute in the playlist pane of the behaviour tab.
This change should be transparent, with the benefits including improved portable playlist library matching, and predictable absolute and relative playlist target paths. In order for the library to start using the absolute paths, the source must be removed and re-added. This will result in the loss of any ratings or play counts not written to file tags.